Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update check_powi.py to handle floats properly #1598

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Update check_powi.py to handle floats properly #1598

merged 5 commits into from
Jun 28, 2024

Conversation

yut23
Copy link
Collaborator

@yut23 yut23 commented Jun 28, 2024 •
edited
Loading

Also check instances of admath::pow in addition to std::pow and gcem::pow.

@yut23 yut23 changed the title Check admath::pow for replacement with amrex::Math::powi Update check_powi.py to handle floats properly Jun 28, 2024
@zingale zingale merged commit 3641c24 into AMReX-Astro:development Jun 28, 2024
30 checks passed
@yut23 yut23 deleted the powi_check_admath branch July 1, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhichen3 zhichen3 zhichen3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yut23 @zhichen3 @zingale